Bug 10510

Summary: OPAC's renew selected link has glitchy icon
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: bgkriegel, gmcharlt, katrin.fischer, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot of the affected image
Bug 10510 - OPAC's renew selected link has glitchy icon
Bug 10510 - OPAC's renew selected link has glitchy icon
[PASSED QA] Bug 10510 - OPAC's renew selected link has glitchy icon

Description Owen Leonard 2013-06-26 15:55:48 UTC
Created attachment 19244 [details]
Screenshot of the affected image

The OPAC image sprite lacks enough whitespace between the "renew selected" image and the following image to display correctly, resulting in a glitchy-looking image. The sprite should be modified to make more room.
Comment 1 Owen Leonard 2013-06-26 17:06:40 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-06-30 07:28:40 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-06-30 09:27:46 UTC
I am sorry, but I can't get this to work for me. I have tested in Firefox and Chromium, deleting my browser cache and it still shows the little bit from the other icon. :(
Comment 4 Owen Leonard 2013-07-01 14:16:12 UTC
This works for me in several different browsers, so I'm not sure what is going on. If you don't mind, please try pulling up the image itself in the browser and refreshing that:

/opac-tmpl/prog/images/sprite.png

And if it still isn't working please post a screenshot with browser info.
Comment 5 Katrin Fischer 2013-07-01 14:18:25 UTC
Will retest - thx for providing the URL :)
Comment 6 Katrin Fischer 2013-07-01 18:45:04 UTC
Created attachment 19324 [details] [review]
[PASSED QA] Bug 10510 - OPAC's renew selected link has glitchy icon

The "renew selected" link on the list of a user's checkouts looks bad
because the next icon in the sprite shows through. This patch modifies
the sprite to give it proper spacing and corrects the CSS to accommodate
the change.

To test, apply the patch, clear your browser cache, and view the
following pages to confirm that the change works:

- With TagsEnabled and TagsInputOnList enabled, view a search results
  page when logged in and when not logged in. Tag links should be
  styled correctly.

- With OpacBrowseResults enabled, open the detail page for any record
  and click the "browse shelf" link. The "forward" and "back" arrows
  should be styled correctly.

- With OpacRenewalAllowed enabled, log in to the OPAC and view your
  checked out items. The "renew selected" and "renew all" links should
  look correct.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Note: this will fix only the prog theme, but not the ccsr theme.
And it works perfectly.
Comment 7 Galen Charlton 2013-07-02 13:26:45 UTC
Pushed to master.  Thanks, Owen!
Comment 8 Tomás Cohen Arazi 2013-07-15 23:41:16 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Owen!
Comment 9 Bernardo Gonzalez Kriegel 2013-08-03 18:12:44 UTC
Pushed to 3.10.x, will be in 3.10.10