Summary: | The prototype for GetBranchCategory and GetBranchCategories is not consistent | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 10508 | ||
Attachments: |
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent
[SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent |
Description
Jonathan Druart
2013-06-28 14:13:36 UTC
Created attachment 19275 [details] [review] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Created attachment 19535 [details] [review] [SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 19597 [details] [review] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. Pushed to master, along with two follow-ups to add a regression test and to fix the call to GetBranchCategories in C4/Auth.pm. This patch (along with Galen's regression tests) has been pushed to 3.12.x, will be in 3.12.4. Thanks Jonathan! |