Bug 10515

Summary: The prototype for GetBranchCategory and GetBranchCategories is not consistent
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 10508    
Attachments: Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent
[SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent

Description Jonathan Druart 2013-06-28 14:13:36 UTC
The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument.
Comment 1 Jonathan Druart 2013-06-28 14:14:36 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-07-11 01:58:06 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2013-07-12 14:33:44 UTC
Created attachment 19597 [details] [review]
Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent

The prototype is not consistent, GetBranchCategory should return only 1 result
and GetBranchCategories should not have a categorycode argument.
This patch fixes that.

Test plan:
1/ Try to add/remove/modify a library.
2/ Add some groups
3/ Add these groups to a library

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, works as advertised.
Comment 4 Galen Charlton 2013-07-17 18:04:55 UTC
Pushed to master, along with two follow-ups to add a regression test and to fix the call to GetBranchCategories in C4/Auth.pm.
Comment 5 Tomás Cohen Arazi (tcohen) 2013-08-13 16:46:24 UTC
This patch (along with Galen's regression tests) has been pushed to 3.12.x, will be in 3.12.4.

Thanks Jonathan!