Summary: | koha_perl_deps.pl miscounts dependencies displayed | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Moved $count++ into if statements to fix miscount.
bug 10548: fix count of missing required dependencies by koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl |
Description
Mark Tompsett
2013-07-06 19:48:23 UTC
Created attachment 19442 [details] [review] Moved $count++ into if statements to fix miscount. TEST ----- $ cd kohaclone $ ./koha_perl_deps.pl -m -u if you have nothing missing, uninstall an optional component. $ ./koha_perl_deps.pl -m -u you should get a number missing of at least 1. $ ./koha_perl_deps.pl -m -u -r you should get the same number, even though the output is less. apply patch $ ./koha_perl_deps.pl -m -u same results $ ./koha_perl_deps.pl -m -u -r the number should differ. Created attachment 19524 [details] [review] bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 19568 [details] [review] bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: Tiny patch. Looks good to me. Passed QA Pushed to master. Thanks, Mark! This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Mark! Pushed to 3.10.x, will be in 3.10.10 |