Summary: | overdue_notices -h does not list all options | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Command-line Utilities | Assignee: | Bugs List <koha-bugs> |
Status: | Failed QA --- | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | [PATCH]Bug 10555: Update list of options displayed by overdue_notices.pl --help |
Description
Mathieu Saby
2013-07-09 09:07:06 UTC
Created attachment 21108 [details] [review] [PATCH]Bug 10555: Update list of options displayed by overdue_notices.pl --help Very cosmetic patch... overdue_notices.pl --help display - an "usage" line - a first list of options, with short descriptions - a long list of options, with long descriptions 4 options are only in the 3rd, long list. They should also be in the "usage" line and in the short list. To test : run perl overdue_notice.pl --help and check all the options are displayed M. Saby Mathieu: Two code snippets: 1: GetOptions( 'date' => \$date, 2: if ($date){ $date=$dbh->quote($date); } else { $date="NOW()"; } It seems like the date parameter gets not correctly passed in. If you specify -date 23-09-2013, it will have value 1 since no value is defined in GetOptions. Since you document it, could you please verify or correct? Thanks. Well, this patch was very cosmetic and did not touch code itself. If something is broken, it must be broken in master. So, we should check on master, and fill a new bug if the issue is confirmed. Mathieu (In reply to mathieu saby from comment #3) > Well, this patch was very cosmetic and did not touch code itself. I was just thinking: If you advertize an option that does not work, probably you should better not advertize it yet. ok, understood. But I would prefer fixing the option ;-) I will take a look Mathieu Just a note: now the --date parameter works as expected. |