Summary: | use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, kyle, mathsabypro, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED OFF] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl [PASSED QA] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl |
Description
Fridolin Somers
2013-07-10 09:06:16 UTC
Created attachment 19514 [details] [review] Proposed patch Test plan in commit message Created attachment 20753 [details] [review] [SIGNED OFF] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl. Test plan : - In a UNIMARC catalog, enable XSLT for OPAC results page - Create a record with a link in 856$u and set second indicator to 0 - Set OPACURLOpenInNewWindow syspref on - At OPAC, perform a search that contains the record => You should see the link : "Click here to access online" - click on it => You shoud get to a new window (or tab depending on your browser configuration) - Set OPACURLOpenInNewWindow syspref off - re-perform the search - click on the link => You shoud stay in same window Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors Tested following plan after applying patch Created attachment 20882 [details] [review] [PASSED QA] Bug 10564 - use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. This patch adds the use of OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl. Test plan : - In a UNIMARC catalog, enable XSLT for OPAC results page - Create a record with a link in 856$u and set second indicator to 0 - Set OPACURLOpenInNewWindow syspref on - At OPAC, perform a search that contains the record => You should see the link : "Click here to access online" - click on it => You shoud get to a new window (or tab depending on your browser configuration) - Set OPACURLOpenInNewWindow syspref off - re-perform the search - click on the link => You shoud stay in same window Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no koha-qa errors Tested following plan after applying patch Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change only, works as described. To test: Catalog 856$u and $a, 2nd indicator = 0. Pushed to master. Thanks, Fridolyn! Do you know if the changes were made too in the new bootstrap opac ? Mathieu (In reply to mathieu saby from comment #5) > Do you know if the changes were made too in the new bootstrap opac ? No they didn't. Must I make a follow-up ? (In reply to Fridolyn SOMERS from comment #6) > (In reply to mathieu saby from comment #5) > > Do you know if the changes were made too in the new bootstrap opac ? > No they didn't. > Must I make a follow-up ? We have now 3 themes for opac. That's a lot ;-) I did not test boostrap opac. Does the xslt have something "special", or are they a mere copy of the xslt of old opac? If so, I suppose all changes made to old xslt should be copied to bootsrap xslt too. Mathieu This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn! This patch has been pushed to 3.8.x, and will be in 3.08.20. Thanks Fridolyn! |