| Summary: | Remove the message about upgrading to 3.4 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Robin Sheat <robin> |
| Component: | Packaging | Assignee: | Robin Sheat <robin> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt, liz, mirko, robin, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Empty package that claims to be koha 3.2.2 for testing upgrades
Bug 10574 - mute the "upgrading from 3.2" message Bug 10574 - mute the "upgrading from 3.2" message Bug 10574 - mute the "upgrading from 3.2" message |
||
|
Description
Robin Sheat
2013-07-11 11:18:16 UTC
Created attachment 19569 [details]
Empty package that claims to be koha 3.2.2 for testing upgrades
Created attachment 19570 [details] [review] Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. This test plan makes me happy. Created attachment 19968 [details] [review] Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Galen approved my change from enhancement to bug for this one. Patch works nicely for me. Thanks for fixing this, it is very confusing to people installing Koha for the first time. I hope to see it in 3.12 and 3.10 too. Created attachment 20823 [details] [review] Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Robin! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Robin! Pushed to 3.10.x, will be in 3.10.12 |