| Summary: | HTML errors on authority detail page in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt, jcamins, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10587 - HTML errors on authority detail page in OPAC
Bug 10587: fix HTML errors on authority detail page in OPAC [PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC |
||
Created attachment 20239 [details] [review] Bug 10587 - HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Created attachment 20336 [details] [review] Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 20666 [details] [review] [PASSED QA] Bug 10587: fix HTML errors on authority detail page in OPAC A validator check of the OPAC's authority detail returns a few minor errors. This patch corrects the errors. To test, apply the patch and run an OPAC authority detail page through an HTML validator. There should be no errors which are specific to the authorities detail template (as opposed to header and footer includes). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Also checked using the W3C validator and testing the authority detail page in the OPAC is still correctly displayed. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! Pushed to 3.10.x, will be in 3.10.12 |
When checking the source code for some ids and classed I found that Firefox showed some red error marks in the source code. It seems 2 divs are closed, but not opened. The W3C HTML validator also points out those: Error Line 357, Column 10: End tag div seen, but there were open elements. </div> Error Line 256, Column 24: Unclosed element ul. <ul class="seefrom"> Error Line 381, Column 6: Stray end tag div. </div>