Summary: | JavaScript indexOf function not supported by IE 7 and 8 | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Browser compatibility | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, marjorie.barry-vila |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 10541 | ||
Bug Blocks: |
Description
Galen Charlton
2013-07-17 16:10:09 UTC
I think one of the problems possibly related to the use of IndexOf is the inability to select irregularities when creating subscriptions in serials. I can't test it here as I don't have an old IE, so that's from my training notes. koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt (In reply to Katrin Fischer from comment #1) > I think one of the problems possibly related to the use of IndexOf is the > inability to select irregularities when creating subscriptions in serials. I > can't test it here as I don't have an old IE, so that's from my training > notes. > koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Based on my (and others) testing of the patch for bug 10541, this sort of thing can be tested in IE 9 or 10 by using "F12 developer tools" to set the browser mode to IE 7 or IE 8. Cool, thx! I've found one template in the Bootstrap theme that is affected: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt Where IE emulation fails, you can always try an IE testing VM as well: www.modern.ie I've been using the Win 7 IE 8 recently and have no complaints. Mind you, they expire after a set period of time, so if it's not easy to "refresh" it...I'll be a bit cranky. I don't think we should not be spending time trying to support IE7 and 8 anymore. (In reply to Owen Leonard from comment #6) > I don't think we should not be spending time trying to support IE7 and 8 > anymore. That is, I don't think we should be spending time trying to support IE7 and 8 anymore. (In reply to Owen Leonard from comment #7) > That is, I don't think we should be spending time trying to support IE7 and > 8 anymore. I agree that there's no point in actively trying to support IE7 and IE8, although as someone who has to support IE7 and IE8 sometimes, I find it nice when people test and QA my code. What I mean to say is... in general we shouldn't claim to support IE7 or IE8 or make concerted efforts to do so... but I don't see why we can't fix individual issues as they arise if someone is willing to code a fix. Personally, I haven't encountered this particular issue, so I have no interest in fixing it if I don't have to, but I don't know if we need to label it as a WONTFIX. (Relevant for anyone searching this in the future: Personally, I think it makes sense to use jQuery's "inArray", since we use a lot of jQuery and it's cross-platform. Obviously not very useful in the case of third-party libraries that we can't re-write. Alternatively, we could use a polyfill: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf) |