| Summary: | Init script cleanup | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Packaging | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 10624 | ||
| Attachments: |
Bug 10617 - koha-common tnit script cleanup
Bug 10617 - koha-common init script cleanup Bug 10617 - koha-common init script cleanup |
||
|
Description
Tomás Cohen Arazi (tcohen)
2013-07-19 20:53:43 UTC
Created attachment 19811 [details] [review] Bug 10617 - koha-common tnit script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Created attachment 19851 [details] [review] Bug 10617 - koha-common init script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. Added a TODO comment regarding the 'status' switch. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Sponsored-by: Universidad Nacional de Cordoba I don't think we need to have PERL5LIB defined in the config for this. It shouldn't break anything though. Created attachment 21218 [details] [review] Bug 10617 - koha-common init script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. Added a TODO comment regarding the 'status' switch. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Pushed to master. Thanks, Tomás! This patch has been pushed to 3.12.x, will be in 3.12.7. |