|
Description
Tomás Cohen Arazi (tcohen)
2013-07-22 15:57:26 UTC
Created attachment 19852 [details] [review] Bug 10622: add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba To test: - pick the koha-list script from this patch, and - test ./koha-list --help, ./koha-list -h for usage options - All switches should work as expected (--noemail --email --sip --nosip). That's it. It might not be a while before I can test this, but I do approve of the idea and at a read the code looks good. So if someone else looks at it first, that's great. Created attachment 20213 [details] [review] Bug 10622: [SIGNED OFF] add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> I applied the patch on my local dev install, and then copied the patched koha-list script to a couple of servers with actual instances running off the packages, to test the script. - It seems that the -h switch did not work before this patch, now both -h and --help works nicely - --sip and --nosip work as expected, also in combination with --email and --noemail The patch does not add --sip and --nosip to the man page for koha-list, but I will do a followup for that. Created attachment 20214 [details] [review] Bug 10622 - Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Created attachment 20221 [details] [review] Bug 10622 - [SIGNED OFF] Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Forgot the docs this time, good catch Magnus Created attachment 21219 [details] [review] Bug 10622: [SIGNED OFF] add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> I applied the patch on my local dev install, and then copied the patched koha-list script to a couple of servers with actual instances running off the packages, to test the script. - It seems that the -h switch did not work before this patch, now both -h and --help works nicely - --sip and --nosip work as expected, also in combination with --email and --noemail The patch does not add --sip and --nosip to the man page for koha-list, but I will do a followup for that. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Created attachment 21220 [details] [review] Bug 10622 - [SIGNED OFF] Followup: Add --sip, --nosip and --help to man page The original patch for bug 10622 added the --sip, --nosip and --help switches to the koha-list command, but did not update the manpage for the command. This patch does. To test: Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Make sure this test passes: $ prove -v xt/verify-debian-docbook.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Forgot the docs this time, good catch Magnus Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Pushed to master. Thanks, Tomás and Magnus! This patch has been pushed to 3.12.x, will be in 3.12.7. |