| Summary: | ModBookseller needs more explicit return values in C4::Bookseller.pm | ||
|---|---|---|---|
| Product: | Koha | Reporter: | kenza <kenza.zaki> |
| Component: | Acquisitions | Assignee: | kenza <kenza.zaki> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kenza.zaki |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10528 | ||
| Bug Blocks: | |||
| Attachments: |
ModBookseller needs more explicit return values in C4::Bookseller.pm
ModBookseller needs more explicit return values in C4::Bookseller.pm [SIGNED-OFF] ModBookseller needs more explicit return values in C4::Bookseller.pm [PASSED QA] ModBookseller needs more explicit return values in C4::Bookseller.pm |
||
|
Description
kenza
2013-07-25 07:49:55 UTC
Created attachment 19938 [details] [review] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/55 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=55, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS Created attachment 19939 [details] [review] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS Created attachment 19990 [details] [review] [SIGNED-OFF] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 20587 [details] [review] [PASSED QA] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Change is logical and passes new and old tests. Fixed the author line to have Kenza's correct email address. Pushed to master. Thanks, Kenza! |