Summary: | Use new DataTables include in administration templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10649 | ||
Bug Blocks: | |||
Attachments: |
Bug 10651 - Use new DataTables include in administration templates
[SIGNED-OFF] Bug 10651 - Use new DataTables include in administration templates Bug 10651 - Use new DataTables include in administration templates Bug 10651 - Followup Use new DataTables include in administration templates |
Description
Owen Leonard
2013-07-26 15:29:31 UTC
Created attachment 20968 [details] [review] Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Created attachment 21259 [details] [review] [SIGNED-OFF] Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors Created attachment 21269 [details] [review] Bug 10651 - Use new DataTables include in administration templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all administration-related pages which use DataTables. To test, view the following pages and confirm that table sorting is still working correctly: - Administration -> Budgets - Administration -> Authority types -> MARC structure - Administration -> Authorized values - Administration -> Library transfer limits - Administration -> Libraries and groups - Administration -> Patron types and categories - Administration -> Cities and towns - Administration -> Item types - Administration -> MARC bibliographic framework -> MARC structure - Administration -> System preferences - Administration -> System preferences -> Local use - Administration -> Z39.50 client targets Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 21270 [details] [review] Bug 10651 - Followup Use new DataTables include in administration templates The aqbudgets.tt needs to use the include file too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> QA comment: The admin fund page was missing. Owen, could you explain me why the css file is not include in the include file please? Marked as Passed QA. (In reply to Jonathan Druart from comment #5) > Owen, could you explain me why the css file is not include in the include > file please? Perhaps it would have been better to do it that way. I was thinking of a time in the future when I would like to move all JavaScript to the end of each page instead of the beginning, and CSS would need to stay at the top. Pushed to master. Thanks, Owen! |