| Summary: | Improve suggestion detail page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, srdjan |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10668 - Improve suggestion detail page
Bug 10668 - Improve suggestion detail page Bug 10668 - Improve suggestion detail page - QA Followup [SIGNED-OFF] Bug 10668 - Improve suggestion detail page - QA Followup [PASSED QA] Bug 10668 - Improve suggestion detail page [PASSED QA] Bug 10668 - Improve suggestion detail page - QA Followup |
||
|
Description
Owen Leonard
2013-07-31 19:36:12 UTC
Created attachment 20018 [details] [review] Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). It is a bit nicer to say
return confirm(_("Are you sure you want to delete this suggestion?"));
rather than
var is_confirmed = confirm(_("Are you sure you want to delete this suggestion?"));
if (is_confirmed) {
return true;
} else {
return false;
}
Created attachment 20072 [details] [review] Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 20073 [details] [review] Bug 10668 - Improve suggestion detail page - QA Followup Created attachment 20102 [details] [review] [SIGNED-OFF] Bug 10668 - Improve suggestion detail page - QA Followup Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Created attachment 20612 [details] [review] [PASSED QA] Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests, nice improvement. Created attachment 20613 [details] [review] [PASSED QA] Bug 10668 - Improve suggestion detail page - QA Followup Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Owen! |