Description
Tomás Cohen Arazi (tcohen)
2013-08-02 18:30:28 UTC
Created attachment 20081 [details] [review] Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 20082 [details]
Snapshot
Everything looks good and works well with one exception: If I click the button without choosing one of the menu choices the framworkcode is passed as "undefined" instead of being empty. With "undefined" the default framework isn't loaded and I get an MARC edit screen with no fields. Created attachment 20085 [details] [review] Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba Created attachment 20088 [details] [review] Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba Created attachment 20261 [details] [review] [Signed off] Bug 10678 - Allow framework selection when creating from Z39.50 Created attachment 20262 [details] [review] [Signed off] Bug 10678 - Update addbooks help page After applying these patches, I can see the "New from Z39.50" button with the arrow for a dropdown of frameworks. I tested this by just clicking the button, going through the usual Z39.50 search and import, and my record was imported with the default framework. I then chose a different framework from the dropdown, went through the usual Z39.50 search and import, and my record was imported with the framework I had selected. I read the update to the help page, and I think everything looks good, so I am signing off. Created attachment 20890 [details] [review] [PASSED QA] Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Notes on second patch. Created attachment 20891 [details] [review] [PASSED QA] Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. If you click the button directly, the default framework is still used. If you use the split button functionality to select another framework, this framework will be used for the imported record. Pushed to master. Thanks, Tomás! This patch has been pushed to 3.12.x, will be in 3.12.5. |