Summary: | Inappropriate uses of finish() in C4::Reserve.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | kenza <kenza.zaki> |
Component: | Architecture, internals, and plumbing | Assignee: | kenza <kenza.zaki> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, kenza.zaki |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10682 : Inappropriate uses of finish() in C4::Reserves
Bug 10682 : Inappropriate uses of finish() in C4::Reserves Bug 10682 : Inappropriate uses of finish() in C4::Reserves |
Description
kenza
2013-08-05 09:42:05 UTC
Created attachment 20108 [details] [review] Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Created attachment 20614 [details] [review] Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors Created attachment 20646 [details] [review] Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed to master. Thanks, Kenza! |