Bug 10690

Summary: Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL
Product: Koha Reporter: Magnus Enger <magnus>
Component: System AdministrationAssignee: Magnus Enger <magnus>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: bgkriegel, gmcharlt, mirko, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL
Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL
[PASSED QA] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL

Description Magnus Enger 2013-08-06 13:51:34 UTC
The descriptions of OPACBaseURL and staffClientBaseURL are not explicit about whether a trailing slash should be included in the URLs or not. But:

<jcamins> Folks: if you have a trailing slash in your OPACBaseURL or staffClientBaseURL, REMOVE IT!
<jcamins> I've been trying to troubleshoot weird firewall issues with 3.12 for one of my clients ever since the upgrade, and it turns out that the firewall was going nuts because of URLs like catalog.com//cgi-bin/koha/opac-detail.pl.
<jcamins> Almost certainly a firewall misconfiguration, of course, but it's easy enough to work around on the server.

Patch coming up!
Comment 1 Magnus Enger 2013-08-06 14:05:21 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-08-08 19:36:20 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-25 20:46:48 UTC
Created attachment 20608 [details] [review]
[PASSED QA] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL

The descriptions for OPACBaseURL and staffClientBaseURL are not explicit
about including a trailing slash or not. This patch makes it explicit
that the trailing slash should *not* be included.

To test:
- Apply the patch
- Search for "baseurl" in the system preferences
- Check that the description of both sysprefs includes a warning about
  not including a trailing slash.
- Sign off

If you want to check that the trailing slash is in fact superfluous you
can do something like 'grep -r "BaseURL" *' and check that these
sysprefs are usually concatenated with some string that starts with a
slash.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changes to the description appear correctly on both system
preferences.
Comment 4 Galen Charlton 2013-08-28 14:15:33 UTC
Pushed to master.  Thanks, Magnus!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-13 17:25:58 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Magnus!
Comment 6 Bernardo Gonzalez Kriegel 2013-10-13 13:24:32 UTC
Pushed to 3.10.x, will be in 3.10.12