| Summary: | DeleteTransfer in C4::Circulation.pm needs return value | ||
|---|---|---|---|
| Product: | Koha | Reporter: | kenza <kenza.zaki> |
| Component: | Architecture, internals, and plumbing | Assignee: | kenza <kenza.zaki> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, chris, gmcharlt, kenza.zaki |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10681, 10692 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value
Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value |
||
|
Description
kenza
2013-08-08 08:36:52 UTC
Created attachment 20160 [details] [review] Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS I cant get this to apply, even after apply 10692 (In reply to Chris Cormack from comment #2) > I cant get this to apply, even after apply 10692 Sorry i forgot to mention it, but this patch also needs to apply 10681. Created attachment 20616 [details] [review] Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches Created attachment 20648 [details] [review] Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed to master. Thanks, Kenza! |