Bug 10701

Summary: In transit information doesn't display on the bibliographic detail page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: bgkriegel, gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10701 - In transit information doesn't display on the bibliographic detail page
Bug 10701 - In transit information doesn't display on the bibliographic detail page
[PASSED QA] Bug 10701 - In transit information doesn't display on the bibliographic detail page

Description Owen Leonard 2013-08-08 19:37:53 UTC
My patch for Bug 10083 may have made the in-transit strings translatable, but it messed up the template variable names so that the details don't show.
Comment 1 Owen Leonard 2013-08-08 19:44:03 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-08-08 20:08:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-17 21:53:23 UTC
Created attachment 20434 [details] [review]
[PASSED QA] Bug 10701 - In transit information doesn't display on the bibliographic detail page

The patch for Bug 10083 incorrectly changed some template variable names
so that in-transit details could not be shown on the biblio detail page.
This patch corrects the error.

To test, perform any action that will trigger an transfer between
libraries (for instance, check in an item from Library A at Library B).
View the detail page for that title and look for the transfer details in
the status column of the holdings table. It should show correct
information:

"In transit from Athens to Nelsonville since 08/08/2013"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Work as described, no errors.
Before patch incorrect information: "In transit from to since"
after patch correct information.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works perfectly and passes all tests.
Comment 4 Galen Charlton 2013-08-19 15:16:47 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Tomás Cohen Arazi 2013-09-13 14:38:05 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Owen!
Comment 6 Bernardo Gonzalez Kriegel 2013-09-14 23:31:10 UTC
Does not apply cleanly to 3.10.x, please submit one formatted for 3.10.x