Summary: | Search term highlighting doesn't work beyond the first results page | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, chrish, jonathan.druart, jonathan.field, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
fix for search term highlighting on record navigation
Hit highlighting not working on Previous & Next buttons Bug 10704: Hit highlighting not working on Previous & Next buttons |
Description
Martin Renvoize (ashimema)
2013-08-09 11:04:23 UTC
To be clear, it is the paging with the "Next" / "Previous" buttons which are affected. So :- Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail). 4) Moving forward or back, the highlighting disappears. Moving from results to the first full record the URL contains the query_desc param from the session data. This is dropped as you navigate back and forth, leaving only the biblionumber. Created attachment 20216 [details] [review] fix for search term highlighting on record navigation To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. Created attachment 20218 [details] [review] Hit highlighting not working on Previous & Next buttons http://bugs.koha-community.org/show_bug.cgi?id=10704 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment: Simple patch. Fix the described issue. I will c/p the test plan on my SO patch. Marked as Passed QA. Created attachment 20459 [details] [review] Bug 10704: Hit highlighting not working on Previous & Next buttons To test Enable 'OpacHighlightedWords' 1) Run a search with multiple results 2) Click on a title of one of the results to get the full record display. Hit highlighting SHOULD work on this page. 3) Use either the "Next" or "Previous" buttons on this page (opac-detail) to move to the next or previous record. 4) Moving forward or back, the highlighting should still be working on the page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan! Pushed to 3.10.x, will be in 3.10.11 Pushed to 3.8.x, will be in 3.8.20. |