Bug 10716

Summary: The booksellers template generates a JS error
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 5766    
Bug Blocks: 10533    
Attachments: Bug 10716: the basketgroup template does not include all datatables file.
Bug 10716: fix JavaScript error on basket groups page
Bug 10716: fix JavaScript error on basket groups page

Description Jonathan Druart 2013-08-13 10:25:15 UTC
Bug 5766 introduces a js error on acqui/basketgroup.tt because it is bad formed (does not include all datatable file).
Comment 1 Jonathan Druart 2013-08-13 10:27:46 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-08-14 14:59:26 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2013-08-16 14:36:23 UTC
Created attachment 20414 [details] [review]
Bug 10716: fix JavaScript error on basket groups page

To test:

Go on acqui/basketgroup.tt and verify a js error occurred
(ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined).
Apply the patch and verify the error does not appear anymore.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Galen Charlton 2013-08-16 14:44:42 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-11 17:19:24 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Jonathan!