Summary: | Improve DataTables configuration on transfers to receive report | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/transferstoreceive.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10721 - Improve DataTables configuration on transfers to receive report
Bug 10721 - Improve DataTables configuration on transfers to receive report [PASSED QA] Bug 10721 - Improve DataTables configuration on transfers to receive report |
Description
Owen Leonard
2013-08-13 18:48:52 UTC
Created attachment 20322 [details] [review] Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Created attachment 20523 [details] [review] Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Signed-off-by: David Cook <dcook@prosentient.com.au> There is no observable difference. The funcitonality is still there. I notice the hidden span is gone when I look at the source. Looks good. Created attachment 20862 [details] [review] [PASSED QA] Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and works nicely. Tested with different date formats. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks Owen! |