|
Description
Kyle M Hall (khall)
2013-08-14 18:25:48 UTC
Created attachment 20351 [details] [review] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Created attachment 20352 [details] [review] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [3.10.x] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Created attachment 20353 [details] [review] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the difference? The unlabeled one is for master, the other applies to 3.10.x and 3.12.x (In reply to Owen Leonard from comment #4) > One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the > difference? Created attachment 20705 [details] [review] [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 20706 [details] [review] [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully in 3.10.x and 3.12.x Created attachment 20907 [details] [review] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 20908 [details] [review] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully in 3.10.x and 3.12.x Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Kyle! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! |