Bug 10736

Summary: AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: AcquisitionsAssignee: Jared Camins-Esakov <jcamins>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart+koha>
Severity: critical    
Priority: P5 - low CC: gmcharlt, jonathan.druart+koha
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 10366    
Bug Blocks:    
Attachments: Bug 10736: show duplicate invoice warning on second invoice
[SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice
Bug 10736: show duplicate invoice warning on second invoice

Description Nicole C. Engard 2013-08-15 15:08:24 UTC
If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate.
Comment 1 Jared Camins-Esakov 2013-08-15 15:30:38 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2013-08-15 16:04:02 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-08-16 10:01:12 UTC
Works as expected, marked as Passed QA.
Comment 4 Jonathan Druart 2013-08-16 10:01:29 UTC
Created attachment 20391 [details] [review]
Bug 10736: show duplicate invoice warning on second invoice

If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2
or more invoices with the same number. It should warn if you're trying to
create a duplicate.

To test:
1) Turn on AcqWarnOnDuplicateInvoice.
2) Try to create an invoice that duplicates an invoice number you are already
   using exactly once.
3) Note that you get a warning after applying this patch.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
all tests pass

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2013-08-16 17:01:27 UTC
Pushed to master.  Thanks, Jared!