Summary: | add style to privacy rules | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Nicole C. Engard <nengard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10743: Add styles to 'my privacy' page in OPAC
[SIGNED-OFF] Bug 10743: Add styles to 'my privacy' page in OPAC [PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC |
Description
Nicole C. Engard
2013-08-16 14:31:39 UTC
Created attachment 20413 [details] [review] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Created attachment 20506 [details] [review] [SIGNED-OFF] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Edit: Replaced a few tabs with spaces to keep the QA script happy. Created attachment 20521 [details] [review] [PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Edit: Replaced a few tabs with spaces to keep the QA script happy. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, privacy options can still be edited. Pushed to master. Thanks, Nicole! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Nicole! |