Summary: | UT: Routines which interact with the table issuingrules in C4/Circulation need unit test | ||
---|---|---|---|
Product: | Koha | Reporter: | kenza <kenza.zaki> |
Component: | Test Suite | Assignee: | kenza <kenza.zaki> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, kenza.zaki, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests
Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests |
Description
kenza
2013-08-20 08:37:35 UTC
Created attachment 20496 [details] [review] Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Created attachment 20619 [details] [review] Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No koha-qa errors prove t/db_dependent/Circulation_Issuingrule.t run without errors Created attachment 20651 [details] [review] Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No koha-qa errors prove t/db_dependent/Circulation_Issuingrule.t run without errors Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed to master. Thanks, Kenza! I did, however, also push a follow-up removing the FIXME comments -- GetIssuingRules() is not a traditional accessor, and should not be returning multiple rules in any event. This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Kenza! |