| Summary: | Javascript error on the parcel page: YAHOO is not defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt, kyle, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10786: Javascript error on the parcel page: YAHOO is not defined
[SIGNED-OFF] Bug 10786: Javascript error on the parcel page: YAHOO is not defined Bug 10786: Javascript error on the parcel page: YAHOO is not defined |
||
|
Description
Jonathan Druart
2013-08-27 10:03:11 UTC
Created attachment 20652 [details] [review] Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page I am still having some problems after this patch is applied - I ran into the problem testing the patch for 10649 - also leaving a note there. Created attachment 20713 [details] [review] [SIGNED-OFF] Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the javascript error pointed out by Firebug. The invoicenumber I used led to a table with over 5.000 entries - using one with less lines this tested nicely. Created attachment 20738 [details] [review] Bug 10786: Javascript error on the parcel page: YAHOO is not defined The include of the yui json file generates a js error: YAHOO is not defined. This file seems not to be in use (patches for bug 8382 remove the use). To test: - go on acqui/parcel.pl?invoiceid=XXX - verify the error occurs (with firebug) - apply this patch - refresh the page - verify this error does not appear anymore - Verify there is no regression on this page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the javascript error pointed out by Firebug. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Jonathan! Pushed to 3.10.x, will be in 3.10.12 |