| Summary: | XSLT change 780/785 search queries to use ti,phr indexes like other linking entries | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Templates | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries
Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries [PASSED QA] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries |
||
|
Description
David Cook
2013-08-28 01:54:20 UTC
Created attachment 20680 [details] [review] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Just changing this away from an enhancement to "minor" as it's really more of a bug fix than an enhancement. Created attachment 20843 [details] [review] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 20860 [details] [review] [PASSED QA] Bug 10793 - XSLT change 780/785 search queries to use ti,phr indexes like other linking entries This patch adds the ti,phr index to the search queries for the 780 and 785 MARC fields in the XSLT templates. Test Plan: 1) Use a record with 780 and 785 MARC fields with data in the "a" or "t" subfields. (You might need to add these fields to an existing record, or create a new record. You might also need to change your MARC Bibliographic Framework settings to not "hide" these fields in your framework(s)). N.B. The data in the "a" or "t" subfields should be a title that exists in your database. Otherwise, this test might seem misleading. 2) Set the system preferences "XSLTDetailsDisplay" and "OPACXSLTDetailsDisplay" to "default". 3) Go to your record (which contains the 780/785 fields), and look for links with linktext derived from the "a" or "t" fields in the record. These may or may not be prefaced with labels such as "Continued by" or "Continues". 4) Note that the links are formatted "q=TITLE". Click this link and note the possibly high number of results. 5) APPLY THE PATCH 6) Shift+Refresh your record page, and observe that the link should now say "q=ti,phr:TITLE". Click this link and note that you are either taken directly to the referenced article or that your search results are considerably fewer. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT change only, no regressions found. Just a note: To my knowledge phrase searches don't work over multiple subfields without additional work/DOM. This patch will create a search string like: ti,phr:<$a><$t>. This seems to produce relevant results, but might not always be as precise as intended. Pushed to master. Thanks, David! A version of this might be applicable to the NORMARC stylesheets. This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks David! Pushed to 3.10.x, will be in 3.10.12 |