Summary: | Improvements for GetOpenIssue in C4::Circulation | ||
---|---|---|---|
Product: | Koha | Reporter: | kenza <kenza.zaki> |
Component: | Architecture, internals, and plumbing | Assignee: | kenza <kenza.zaki> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, jonathan.druart, kenza.zaki |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10683 | ||
Bug Blocks: | |||
Attachments: |
Bug 10795 - Improvements for GetOpenIssue in C4::Circulation
[SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation Bug 10795 - Improvements for GetOpenIssue in C4::Circulation |
Description
kenza
2013-08-28 08:31:45 UTC
Created attachment 20690 [details] [review] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Created attachment 20748 [details] [review] [SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Same situation as the one noted in comment of Bug 10683, test fails unless there is an issuingrule All, All with 1 as renewals allowed. With that condition, it succeeds No koha-qa errors Created attachment 20828 [details] [review] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Same situation as the one noted in comment of Bug 10683, test fails unless there is an issuingrule All, All with 1 as renewals allowed. With that condition, it succeeds No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Kenza! |