Summary: | history.txt missing in packages | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Packaging | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, mtj, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 10802: Packages should install history.txt
Bug 10802: Packages should install history.txt Bug 10802: Packages should install history.txt |
Description
Tomás Cohen Arazi (tcohen)
2013-08-29 17:55:22 UTC
Created attachment 20725 [details] [review] Bug 10802: Packages should install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] To test: - Take a picture of how /usr/share/doc/koha-common looks. - Apply the patch and build a package [2]. - Upgrade and/or install using your package. - Look for the contents of the /usr/share/doc/koha-common, it should look the same, but history.txt must be there. - More > About Koha > Koha Timeline should show the history lines. Regards To+ [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. [2] I did it for you, it can be grabbed here: http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb Sponsored-by: Universidad Nacional de Cordoba Created attachment 20842 [details] [review] Bug 10802: Packages should install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] To test: - Take a picture of how /usr/share/doc/koha-common looks. - Apply the patch and build a package [2]. - Upgrade and/or install using your package. - Look for the contents of the /usr/share/doc/koha-common, it should look the same, but history.txt must be there. - More > About Koha > Koha Timeline should show the history lines. Regards To+ [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. [2] I did it for you, it can be grabbed here: http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 21062 [details] [review] Bug 10802: Packages should install history.txt While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to debian/koha-common.docs. - Adds an override_dh_compress entry in debian/rules that excludes history.txt from the dh_compress routine [1] To test: - Take a picture of how /usr/share/doc/koha-common looks. - Apply the patch and build a package [2]. - Upgrade and/or install using your package. - Look for the contents of the /usr/share/doc/koha-common, it should look the same, but history.txt must be there. - More > About Koha > Koha Timeline should show the history lines. Regards To+ [1] As 'man dh_compress' says, it is needed as every file considered for the doc dir that is plain text and is more than 4k size will be gzipped unless stated otherwise. We need it uncompressed for about.pl. [2] I did it for you, it can be grabbed here: http://ubuntu.unc.edu.ar/koha/koha-common_3.13-1~git+20130829144510.18a6876b_all.deb Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com> simple patch, passing QA Pushed to master. Thanks, Tomás! This patch has been pushed to 3.12.x, will be in 3.12.6. |