Summary: | System preference OAI-PMH:ConfFile isn't translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, fridolin.somers, gmcharlt, josef.moravec, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable
Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable [PASSED QA] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable |
Description
Josef Moravec
2013-09-04 11:39:12 UTC
Bug still valid on current master branch. Not only that text is not translated. Also file description is missing in english. Created attachment 26519 [details] [review] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Created attachment 26697 [details] [review] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. I think the step Mark was missing is 5.5 reinstall the templates. :) Bernardo, thx a lot for tackling all those translation problems! Created attachment 26699 [details] [review] [PASSED QA] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works for me as described, only changes YAML pref file. Pushed to master. Thanks, Bernardo! Pushed to 3.14.x, will be in 3.14.09 Pushed to 3.12.x, will be in 3.12.14 |