Bug 10840

Summary: Re-add missing [% OPACResultsSidebar %]
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %]
Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %]
Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %]
[PASSED QA] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %]

Description Mark Tompsett 2013-09-07 15:25:04 UTC
Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResults Sidebar %] from the opac-facets.inc file. This bug rectifies that problem.

Test Plan:
Confirm the problem
===================
1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text.
2) In the OPAC, search for something
3) In the facets list on the left, the text should appear.
4) Using master installation, set OPACResultsSidebar system preference to some text.
5) In the OPAC, search for something
6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">.

Correct the problem
===================
1) Apply the patch to the master system
2) In the OPAC, search again for something
3) The facets on the left will now have the text showing similar to the 3.12.4 version.
Comment 1 Mark Tompsett 2013-09-07 15:43:46 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2013-09-07 15:45:16 UTC
See the test plan in the first comment.
Comment 3 Tomás Cohen Arazi 2013-09-11 15:05:55 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-09-12 05:46:11 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-09-12 05:47:13 UTC
Created attachment 21000 [details] [review]
[PASSED QA] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %]

Bug 10405 rightly added id's to items, but inadvertently removed
[% OPACResultsSidebar %] from the opac-facets.inc file. This
bug rectifies that problem.

Test Plan:
Confirm the problem
===================
1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text.
2) In the OPAC, search for something
3) In the facets list on the left, the text should appear.
4) Using master installation, set OPACResultsSidebar system preference to some text.
5) In the OPAC, search for something
6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">.

Correct the problem
===================
1) Apply the patch to the master system
2) In the OPAC, search again for something
3) The facets on the left will now have the text showing similar to the 3.12.4 version

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Is back! OPACResultsSidebar is back!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Copied test plan from bug report into commit message.
Template only change, works as expected.
Comment 6 Galen Charlton 2013-09-16 15:36:40 UTC
Pushed to master.  Thanks, Mark!