Summary: | Edit/Delete item context links in items table are not translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10841: Make edit/delete item context links in cataloguing translatable
[SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable Bug 10841: Make edit/delete item context links in cataloguing translatable |
Description
Katrin Fischer
2013-09-07 23:06:34 UTC
Created attachment 20868 [details] [review] Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Created attachment 20911 [details] [review] [SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 20919 [details] [review] Bug 10841: Make edit/delete item context links in cataloguing translatable HTML created with Javascript is not translatable the way HTML is normally translated. _() syntax has to be used to have strings translatable. To test: - Edit items for a record with multiple items - Click somewhere in the items table - Verify the links for editing and deleting items show up and work correctly - Apply patch - Verify the links still show the same behaviour Bonus: - Run 'perl translate update <languagecode>' in misc/translator - Verify that Edit item and Delete item show up in the po file, translate them - Install updated po files running 'perl translate install <languagecode>' - Verify links show up translated and work correctly Patch also fixes capitalization for a couple of error messages - only change there is: Deleted > deleted. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Katrin! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! |