Bug 10847

Summary:	Open external link to website of a vendor in new tab/window
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Acquisitions	Assignee:	Katrin Fischer <katrin.fischer>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	trivial
Priority:	P5 - low	CC:	gmcharlt, m.de.rooy, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 10847: Open link to vendor's website in new window [SIGNED-OFF] Bug 10847: Open link to vendor's website in new window Bug 10847: Open link to vendor's website in new window

Description Katrin Fischer 2013-09-09 15:18:40 UTC

The link to the vendor's website is a link external to Koha and should open in a new tab/window depending on browser settings.

Comment 1 Katrin Fischer 2013-09-10 19:26:39 UTC Comment hidden (obsolete)

Created attachment 20972 [details] [review]
Bug 10847: Open link to vendor's website in new window

To test:
- Create a new vendor or edit an existing one
- Make sure you have entered a valid URL for the website
- Click the link from the vendor summary page and verify it opens
  in a new window/tab (depending on your browser configuration)

Comment 2 Owen Leonard 2013-09-12 17:19:54 UTC Comment hidden (obsolete)

Created attachment 21050 [details] [review]
[SIGNED-OFF] Bug 10847: Open link to vendor's website in new window

To test:
- Create a new vendor or edit an existing one
- Make sure you have entered a valid URL for the website
- Click the link from the vendor summary page and verify it opens
  in a new window/tab (depending on your browser configuration)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Marcel de Rooy 2013-09-23 10:45:55 UTC

Created attachment 21356 [details] [review]
Bug 10847: Open link to vendor's website in new window

To test:
- Create a new vendor or edit an existing one
- Make sure you have entered a valid URL for the website
- Click the link from the vendor summary page and verify it opens
  in a new window/tab (depending on your browser configuration)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Marcel de Rooy 2013-09-23 10:50:53 UTC

Changed importance. Looks good to me.

Passed QA

Comment 5 Galen Charlton 2013-09-23 16:11:14 UTC

Pushed to master.  Thanks, Katrin!

Comment 6 Tomás Cohen Arazi (tcohen) 2013-11-13 16:24:06 UTC

This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Katrin!