Summary: | Give Quick spine label template page its own id | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gitbot, gmcharlt, paola.rossi, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 9618 | ||
Bug Blocks: | |||
Attachments: |
Bug 10850 - Give Quick spine label template page its own id
Give Quick spine label template page its own id Bug 10850 - Give Quick spine label template page its own id |
Description
Katrin Fischer
2013-09-10 06:45:20 UTC
Created attachment 20993 [details] [review] Bug 10850 - Give Quick spine label template page its own id Out of three conditional cases for display of the <body> tag one lacked a unique ID. This patch copies the unique ID from the other cases to the one lacking. This patch also corrects the case of an "onload" attribute which should follow XHTML style rules. To test, the patch for Bug 9618 must be applied. Set the SpineLabelAutoPrint system preference to "[don't] automatically pop up a print dialog." Submit a barcode on the quick spine label creator and view source. The <body> tag should have an ID attribute. Patch applied cleanly, go forth and signoff Created attachment 21852 [details] [review] Give Quick spine label template page its own id I sign off the patch Created attachment 21973 [details] [review] Bug 10850 - Give Quick spine label template page its own id Out of three conditional cases for display of the <body> tag one lacked a unique ID. This patch copies the unique ID from the other cases to the one lacking. This patch also corrects the case of an "onload" attribute which should follow XHTML style rules. To test, the patch for Bug 9618 must be applied. Set the SpineLabelAutoPrint system preference to "[don't] automatically pop up a print dialog." Submit a barcode on the quick spine label creator and view source. The <body> tag should have an ID attribute. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, OWEN! This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! |