Summary: | Use new DataTables include in catalog templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, jonathan.druart |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 10868 - Use new DataTables include in catalog templates
[SIGNED-OFF] Bug 10868 - Use new DataTables include in catalog templates Bug 10868 - Use new DataTables include in catalog templates |
Description
Owen Leonard
2013-09-10 16:18:07 UTC
Created attachment 20969 [details] [review] Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Created attachment 21260 [details] [review] [SIGNED-OFF] Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors. Created attachment 21271 [details] [review] Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: On the issue history page: 1/ If the checkin on is empty (the item is currently checked out), the line is sorted in last. 2/ The Renewed column is not sorted by date. Before this patch, the sort was worse. I added a new test in qa tools in order to avoid new insertion of "jquery.dataTables.min.js". Pushed to master. Thanks, Owen! |