Summary: | Batch item deletion -- doesn't need Use default values section | ||
---|---|---|---|
Product: | Koha | Reporter: | HB-NEKLS <gwilliams> |
Component: | Tools | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | abbyrobertson.student, chris, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 9533 | ||
Bug Blocks: | |||
Attachments: |
Bug 10887: Batch item deletion -- doesn't need Use default values section
Bug 10887: Batch item deletion -- doesn't need Use default values section [SIGNED OFF] Bug 10887: Batch item deletion -- doesn't need Use default values section [PASSED QA] Bug 10887: Batch item deletion -- doesn't need Use default values section |
Description
HB-NEKLS
2013-09-13 16:01:57 UTC
Hi Heather, good catch - it makes no sense there. Created attachment 35319 [details] [review] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Hi Abby, the same page (bachMod.tt) is used for 2 tools: batch item modification and batch item delete. The 'default values' option only makes sense if you want to batch modify, but not if you want to batch delete. Your patch removes from both tools, what we need is some kind of condition, so it shows only for one, but not the other. Created attachment 35934 [details] [review] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Created attachment 36050 [details] [review] [SIGNED OFF] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick <Nick@quechelibrary.org> Created attachment 36070 [details] [review] [PASSED QA] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick <Nick@quechelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Abby! Pushed to 3.18.x will be in 3.18.6 release |