Summary: | Add a --verbose option to koha-translate | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, robin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10896: Add a --verbose option to koha-translate
Bug 10896: Add a --verbose option to koha-translate [SIGNED-OFF] Bug 10896: Add a --verbose option to koha-translate [PASSED QA] Bug 10896: Add a --verbose option to koha-translate |
Description
Magnus Enger
2013-09-16 17:41:06 UTC
Created attachment 23954 [details] [review] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba The options seem to do their job nicely, but I see one small problem in the man page: <arg>[<option>-v</option>|<option>--verbose</option>]</arg> The literal brackets [] result in double brackets in the man page: koha-translate [-i|--install] [-u|--update] [-r|--remove] [-c|--check] [[-v|--verbose]] {lang_code} Just remove the literal brackets and it should be OK. But while yu are in there, could you also put the two synopsis'es (?) into separate <cmdsynopsis>? From this: <refsynopsisdiv> <cmdsynopsis> <command>koha-translate</command> <arg><option>-i</option>|<option>--install</option></arg> <arg><option>-u</option>|<option>--update</option></arg> <arg><option>-r</option>|<option>--remove</option></arg> <arg><option>-c</option>|<option>--check</option></arg> <arg>[<option>-v</option>|<option>--verbose</option>]</arg> <arg choice="req" rep="norepeat"><replaceable>lang_code</replaceable></arg> <command>koha-translate</command> <arg><option>-l</option>|<option>--list</option></arg> <arg><option>-a</option>|<option>--available</option></arg> </cmdsynopsis> </refsynopsisdiv> To this: <refsynopsisdiv> <cmdsynopsis> <command>koha-translate</command> <arg><option>-i</option>|<option>--install</option></arg> <arg><option>-u</option>|<option>--update</option></arg> <arg><option>-r</option>|<option>--remove</option></arg> <arg><option>-c</option>|<option>--check</option></arg> <arg>[<option>-v</option>|<option>--verbose</option>]</arg> <arg choice="req" rep="norepeat"><replaceable>lang_code</replaceable></arg> </cmdsynopsis> <cmdsynopsis> <command>koha-translate</command> <arg><option>-l</option>|<option>--list</option></arg> <arg><option>-a</option>|<option>--available</option></arg> </cmdsynopsis> </refsynopsisdiv> As it is now, the two lines are run into one, this will put them on separate lines. Created attachment 24105 [details] [review] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 24231 [details] [review] [SIGNED-OFF] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as expected with and without -v. Man page looks good. Created attachment 24241 [details] [review] [PASSED QA] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as expected with and without -v. Man page looks good. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Tomás! Patch pushed to 3.14.x, will be in 3.14.4. This patch has been pushed to 3.12.x, will be in 3.12.11. |