Summary: | Highlight patrons from logged-in library in patron searches | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall, sally.healey |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This enhancement highlights the branch when searching for patrons from the currently-logged-in library.
This includes:
- The "Check out" tab in the staff interface header:
. autocomplete results now show the library name. It's highlighted in green for patrons from the currently logged-in library
. after submitting a partial name, the library name for patrons from the currently logged-in library is also highlighted in green
- Browsing for patrons: the library name for patrons from the currently logged-in library is highlighted in green.
|
|
Version(s) released in: |
21.11.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 30251, 34940 | ||
Attachments: |
Bug 10902: Highlight patrons from logged-in library in patron searches
Bug 10902: Highlight patrons from logged-in library in patron searches Bug 10902: Highlight patrons from logged-in library in patron searches Bug 10902: (QA follow-up) Show library name instead of code Bug 10902: Highlight patrons from logged-in library in patron searches Bug 10902: (QA follow-up) Show library name instead of code Bug 10902: (follow-up) Fix patron search autocomplete Bug 10902: (follow-up) Account for singleBranchMode Bug 10902: Highlight patrons from logged-in library in patron searches Bug 10902: (QA follow-up) Show library name instead of code Bug 10902: (follow-up) Fix patron search autocomplete Bug 10902: (follow-up) Account for singleBranchMode Bug 10902: Use prefetch and dbic rs |
Description
Nicole C. Engard
2013-09-17 16:43:19 UTC
Created attachment 119023 [details] [review] Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Created attachment 119037 [details] [review] Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind <david@davidnind.com> Nice! I like it. Created attachment 119057 [details] [review] Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> +1 this is great! I really like the idea of this, but I am not sure about the use of branchcode. We usually avoid the display of branchcodes everywhere and I feel like we should not break the display pattern here, even if it has the advantage of being shorter. I have to admit, since we use the MarcOrgCode for the branchcode in our libraries, a lot of the library staff are currently not aware of the codes and which library it belongs to. This especially applies to student workers. Created attachment 123578 [details] [review] Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. Created attachment 123587 [details] [review] Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Created attachment 123588 [details] [review] Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. Signed-off-by: David Nind <david@davidnind.com> Would it be asking too much for the follow up (using the full library name rather than the library code) to work on the "Search patrons" tab in the header when in the patrons module? I can create a separate bug if that would be preferable. It is such a nice enhancement! Created attachment 123639 [details] [review] Bug 10902: (follow-up) Fix patron search autocomplete The circulation search autocomplete (e.g. from circulation.pl search header) was corrected in the previous patch to include library name instead of branchcode. This patch makes the same correction for patron search autocomplete (e.g. from members-home.pl search header). Thanks Owen! That works brilliantly! David This appears to work really well now! Before passing just one more suggestion to discuss: Could we imagine not displaying this information for single branch libraries by default? I think it would help to keep their display a little cleaner without the highlighting and repeated information. I believe we do have a global variable that could be used for this check: singleBranchMode from C4:Auth.pm. Created attachment 123680 [details] [review] Bug 10902: (follow-up) Account for singleBranchMode This patch checks singleBranchMode before highlighting the current branch in search results. Created attachment 123681 [details] [review] Bug 10902: Highlight patrons from logged-in library in patron searches This patch alters a few different patron search interfaces so that patrons from the currently-logged-in library are highlighted in a way that differentiates them from other patrons. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In Administration -> System preferences, make sure the PatronAutoComplete preference is enabled. - In the "Check out" tab in the header, type a partial patron name which will return multiple results and wait for the autocomplete menu to appear.. - Patrons in the autocomplete results should show the branchcode, and patrons from the currently-logged-in library should be highlighted in green. - Submit your partial name in the "check out" tab. - In the search results the branch name of patrons from the currently-logged-in library should be similarly highlighted. - Go to patrons browse for patrons. These results should be highlighted as in the previous steps. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123682 [details] [review] Bug 10902: (QA follow-up) Show library name instead of code This patch modifies the patron search autocomplete so that library name is shown instead of library code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123683 [details] [review] Bug 10902: (follow-up) Fix patron search autocomplete The circulation search autocomplete (e.g. from circulation.pl search header) was corrected in the previous patch to include library name instead of branchcode. This patch makes the same correction for patron search autocomplete (e.g. from members-home.pl search header). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123684 [details] [review] Bug 10902: (follow-up) Account for singleBranchMode This patch checks singleBranchMode before highlighting the current branch in search results. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 123849 [details] [review] Bug 10902: Use prefetch and dbic rs Pushed to master for 21.11, thanks to everybody involved! |