Summary: | Showing the staff members name who managed a suggestion should be optional | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, m.de.rooy, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC
Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC |
Description
Katrin Fischer
2013-09-17 22:50:42 UTC
Created attachment 23359 [details] [review] Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Created attachment 23752 [details] [review] Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised, the only little nitpick is you could just do [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] However you are following the custom in that file already, so that's fine Created attachment 24449 [details] [review] Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised, the only little nitpick is you could just do [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] However you are following the custom in that file already, so that's fine Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me. No koha-qa complaints. Passed QA Pushed to master, along with a follow-up to repair table sorting. Thanks, Katrin! This king of patch could be done using the base offered by bug 10212. It will avoid to create yasp. I did this mostly thinking about data privacy as we have to use personalized accounts for each staff member. So JQuery/CSS was not enough to achieve the goal here and hide the information safely. Yes sorry, you are right. I did not think about the data privacy problem. Just trying to explain - I agree it's a pref for a small thing :) |