Summary: | C4::Utils becomes useless | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gitbot, gmcharlt, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 10925 | ||
Bug Blocks: | |||
Attachments: |
Bug 10927: C4::Utils is unused
Bug 10927: C4::Utils is unused [SIGNED OFF] Bug 10927: C4::Utils is unused Bug 10927: C4::Utils is unused |
Description
Jonathan Druart
2013-09-20 15:40:12 UTC
Created attachment 21283 [details] [review] Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Patch applied cleanly, go forth and signoff Patch applied cleanly, go forth and signoff $ grep -l hashdump `find .` ./C4/Auth_with_ldap.pm ./C4/Utils.pm ./t/db_dependent/Context.t $ grep -l maxwidth `find .` ./C4/Utils.pm ./C4/Images.pm ./t/db_dependent/Context.t Checking C4/Images.pm showed that wasn't applicable. Checking C4/Auth_with_ldap.pm showed that it was applicable. I think it is triggered by the LDAP user existing locally and debug turned on, but I didn't try to figure out expressly. I eyeballed the patch and was wondering why the "Examining defined key values" section was cut, and not changed. Is there a reason to cut it? Perhaps it makes the test look prettier. :) Did you apply dependent patches? Okay, that solves the mystery of the Auth_with_ldap.pm, but that doesn't answer the question about why cut the "Examining defined key values" section. Created attachment 21425 [details] [review] Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Your Name <you@example.org> Created attachment 21426 [details] [review] [SIGNED OFF] Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Mark Tompsett <mtompset@hotmail.com> $ git bz apply 10925 $ git bz apply 10927 $ prove -v t/db_dependent/Context.t I also confirmed that t/Utils.t was removes, and C4/Utils.pm was as well. I did not do an LDAP login. However, that should be tested with 10925. I did not do a CAS login. However, this eyeballs rather easily, in my opinion. (In reply to M. Tompsett from comment #6) > Okay, that solves the mystery of the Auth_with_ldap.pm, but that doesn't > answer the question about why cut the "Examining defined key values" section. Hello Mark, I removed the section because it was only a display. Being into a unit test file, I don't think it is useful to keep it. This is BLOCKED, because 10925 still waits for sign-off. Perhaps it is premature, but I switched this to signed off, as I got around to testing 10925 and signing it off. Please leave at BLOCKED, it can go back to Signed off when the dependency is resolved. (In reply to Katrin Fischer from comment #13) > Please leave at BLOCKED, it can go back to Signed off when the dependency is > resolved. Hi Katrin, I'm not sure to understand : if the dependency is signed off, I think this one could be have a signed off status too. On this way, 2 patches could be QA together, don't you think? Hm, I thought it was Failed QA when I checked - so there was not much one could do here. Created attachment 21761 [details] [review] Bug 10927: C4::Utils is unused Bug 10925 removes the last call to C4::Utils. The module becomes useless and can be deleted. Verify that t/db_dependent/Context.t still successfully passes. git grep hashdump git grep maxwidth Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, no subs from the module are used anywhere Pushed to master. Thanks, Jonathan! |