Description
Mathieu Saby
2013-09-30 19:57:39 UTC
Created attachment 60227 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Hi Aleisha, the feature works fine. However, can we have an additional link "Show all baskets"? Created attachment 60283 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Created attachment 60293 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron@veron.ch> Aleisha, I think the wording of the button you add is wrong. It says "Show all baskets", but when you are on the screen you are redirected to there is also a "Show all baskets". This one set a allbaskets parameter to the url. I'd suggest more something like "Show baskets from all vendors", or something like that. What do you think? (In reply to Jonathan Druart from comment #5) > Aleisha, I think the wording of the button you add is wrong. > It says "Show all baskets", but when you are on the screen you are > redirected to there is also a "Show all baskets". This one set a allbaskets > parameter to the url. > I'd suggest more something like "Show baskets from all vendors", or > something like that. > What do you think? I see what you mean. I think maybe "Show all active baskets" is more appropriate, seeing as the "Show all baskets" link on the page you are taken to toggles between "Show all baskets" and "Show active baskets only". "Show baskets from all vendors is kind of the same as "Show all baskets" in this case. Created attachment 60365 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 60371 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron@veron.ch> Re-tested. Wording of buttons "Show baskets for vendor..." and "Show all active baskets" makes sense. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 60449 [details] [review] Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc Véron <veron@veron.ch> Re-tested. Wording of buttons "Show baskets for vendor..." and "Show all active baskets" makes sense. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Aleisha! This won't get ported back to 16.11.x as it is an enhancement. |