Summary: | JS error on the cart page | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, paola.rossi, paul.poulain, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9218 | ||
Attachments: |
Bug 11003: intranet cart email broken
Bug 11003: JS error on the cart page JS error on the cart page Bug 11003: JS error on the cart page [PASSED QA] Bug 11003: JS error on the cart page |
Description
Jonathan Druart
2013-10-07 09:41:08 UTC
Created attachment 21846 [details] [review] Bug 11003: intranet cart email broken A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - try to send the cart, the url is basket/sendbasket.pl?bib_list=null - apply the patch - reload the cart view - try to send the cart, the url is now basket/sendbasket.pl?bib_list=X,Y,Z I think that the situation is modified by bug 9218 "intranet cart email broken for non english templates (edit)". After applying 9218, and trying to send the cart, the url is not basket/sendbasket.pl?bib_list=null So I can't sign off. Created attachment 21933 [details] [review] Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. Paola, Yes you are right, but the js error still occurs, it should be fixed. I updated the path. Created attachment 21935 [details] [review] JS error on the cart page Thanks, Jonathan. I confirm that the patch fixes the js error. I sign off the patch. QA comment : * one-liner * I've checked that there is no other reference to yuiToolbar() in the code * passes koha-qa.pl passed QA Created attachment 22181 [details] [review] Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Current status: Passed QA Created attachment 22184 [details] [review] [PASSED QA] Bug 11003: JS error on the cart page A call to yuiToolbar breaks js code on the cart page. Test plan: - add some biblio to your cart - open the cart - a js error occurs (see it with firebug): ReferenceError: yuiToolbar is not defined - apply the patch - retry and verify the error does not appear anymore. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Works as described. Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! |