Description
Mathieu Saby
2013-10-09 11:53:47 UTC
Created attachment 21928 [details] [review] [PATCH 1] Suppress unneeded fields in unimarc_complet default Framework First patch, for "complete" framework, used by academic libray 900, 901, 910, 918, 920,950,960,970,980,987 fields were useless. I removed them. I kept only the fields mentionned in Sudoc documentation http://documentation.abes.fr/sudoc/formats/loc/index.htm 916 field is not cited in that page, but it belongs to Sudoc format. I kept also 2 fields specific to Electre in 2013 : 902 niveau de lecture (Electre) 903 indexation (Electre) I also added to the name of the 9XX fields I kept the mention (Sudoc) / (Electre) / (Koha), so it could be easier for librarians to know what is the purpose and the origin of each field I don't make an updatedatabase, because some libraries could still be using these fields for good or bad reasons. To test : 1) take a fresh Koha with unimarc marcflavor 2) in web installer, select french language, unimarc marflavor and "Grilles de catalogage complètes". 3) check default framework in Administration > MARC Frameworks : it should be without 900,901,910,918,920,950,970,980,987 You can test and sign off even if I did not write yet the patch for "public libraries" framework. Mathieu Created attachment 21929 [details] [review] [PATCH 1] Bug 11021: Suppress unneeded fields in unimarc_complet default Framework correct a typo This bug will be only for french unimarc_complet default Framework. An other bug will be filled for french unimarc for public library, as the case may be different M. Saby Patch applied cleanly, go forth and signoff Id like to sign off on this, but know nothing about UNIMARC, can a UNIMARC user please look at this? This removes a number of obsolete and non-standard fields from the default french unimarc framework, and clarifies the origin of non standard fields that were left. This is highly welcome. Just one remark : 099 seems to be the unimarc equivalent of the marc21 942. It is not defined in the framework, but some values appear in the zebra default configuration. I would suggest to put everything in there, that is to remove total issues from 942, and have 099 defined in the default framework so that we have : 099$c --> biblio.datecreated 099$d --> biblio.timestamp 099$t --> biblioitems.itemtype (his field is indexed unde the ccode index, in case the library uses this as a bibliographic level criteria that is independent from the circulation rules.) 099$x --> biblioitems.totalissues This would of course require to change the zebra index for totalissues in unimarc. Appart from this the patch applies fine and i am willing to sign it off. 099c and d already exist in the default framework. I am making a followup to add x and t, and remove 942. (In reply to Gaetan Boisson from comment #8) > 099c and d already exist in the default framework. I am making a followup to > add x and t, and remove 942. Hello If you want to add new fields for 099 in standard framework, don't you think it could be done in a new bug? When I wrote this one, I deliberately separated this patch from bug 11030 (depends on bug 11021), that adds new fields (359, 947 and 969), as I viewed it as a distinct issue. I thought it would be cleaner to test. But do as you want ;-) Mathieeu Created attachment 28520 [details] [review] BZ 11021 - Delete useless 9XX field in french unimarc_complet default Framework. This removes the 942 field, and adds missing subfields in 099 instead. SOrry i got carried away doing something else and didn't see your message Mathieu. My follow up includes some additions, but i think it's ok since it's a very simple patch. Removing the 942 makes it impossible to apply 11030 before this one is pushed it seems. Well, I have just a little reserve : with your followup, this bug is both written by you and me, so maybe we need a third person to sign it off (not sure of it)? If you move your followup to an other bug, I could be able to sign this new bug, and you or some colleague of yours bug 11021. Mathieu Ok i will use bug 11586 to propose futher changes then. Created attachment 28608 [details] [review] Bug 11021: Suppress unneeded fields in unimarc_complet default Framework First patch, for "complete" framework, used by academic libray 900, 901, 910, 918, 920,950,960,970,980,987 fields were useless. I removed them. I kept only the fields mentionned in Sudoc documentation http://documentation.abes.fr/sudoc/formats/loc/index.htm 916 field is not cited in that page, but it belongs to Sudoc format. I kept also 2 fields specific to Electre in 2013 : 902 niveau de lecture (Electre) 903 indexation (Electre) I also added to the name of the 9XX fields I kept the mention (Sudoc) / (Electre) / (Koha), so it could be easier for librarians to know what is the purpose and the origin of each field I don't make an updatedatabase, because some libraries could still be using these fields for good or bad reasons. To test : 1) take a fresh Koha with unimarc marcflavor 2) in web installer, select french language, unimarc marflavor and "Grilles de catalogage complètes". 3) check default framework in Administration > MARC Frameworks : it should be without 900,901,910,918,920,950,970,980,987 Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> thank you ;-) Created attachment 28713 [details] [review] Bug 11021: Suppress unneeded fields in unimarc_complet default Framework First patch, for "complete" framework, used by academic libray 900, 901, 910, 918, 920,950,960,970,980,987 fields were useless. I removed them. I kept only the fields mentionned in Sudoc documentation http://documentation.abes.fr/sudoc/formats/loc/index.htm 916 field is not cited in that page, but it belongs to Sudoc format. I kept also 2 fields specific to Electre in 2013 : 902 niveau de lecture (Electre) 903 indexation (Electre) I also added to the name of the 9XX fields I kept the mention (Sudoc) / (Electre) / (Koha), so it could be easier for librarians to know what is the purpose and the origin of each field I don't make an updatedatabase, because some libraries could still be using these fields for good or bad reasons. To test : 1) take a fresh Koha with unimarc marcflavor 2) in web installer, select french language, unimarc marflavor and "Grilles de catalogage complètes". 3) check default framework in Administration > MARC Frameworks : it should be without 900,901,910,918,920,950,970,980,987 Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I have complete confidence in Mathieu and Gaetan work. Marked as Passed QA. Patch pushed to master. Thanks Mathieu! Pushed to 3.16.x for inclusion in 3.16.2. |