Summary: | In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar | ||
---|---|---|---|
Product: | Koha | Reporter: | Mathieu Saby <mathsabypro> |
Component: | Acquisitions | Assignee: | Mathieu Saby <mathsabypro> |
Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, paul.poulain, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
[PATCH] Bug 11033 Make Save button and Cancel link always visible on basketgroup page
Bug 11033 Make Save button and Cancel link always visible on basketgroup page Bug 11033 Make Save button and Cancel link always visible on basketgroup page |
Description
Mathieu Saby
2013-10-10 11:43:01 UTC
Created attachment 21943 [details] [review] [PATCH] Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. By the way, the code of this template file is pretty ugly, but that's not the problem here ;-) M. Saby Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> Created attachment 21962 [details] [review] Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> QA comment: * code removal only * passes koha-qa.pl (of course, considering it's removing code only) * regression test = everything fine if there's no language bar with the patch (as it was without) passed QA Created attachment 22191 [details] [review] Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> (In reply to Paul Poulain from comment #5) > QA comment: > * code removal only > * passes koha-qa.pl (of course, considering it's removing code only) > * regression test = everything fine if there's no language bar with the > patch (as it was without) > > passed QA I did think of regression test ;-) Mathieu Pushed to master. Thanks, Mathieu! |