Description
Blou
2013-10-10 15:51:41 UTC
Created attachment 21952 [details] [review] Bug 11035 - (first patch) Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Note for QA: circ/offline-mf.tt uses jquery.hotkeys.min.js too. Created attachment 22311 [details] [review] Bug 11035 - (patching the patch) Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Created attachment 22415 [details] [review] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 22416 [details] [review] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Blou from comment #3) > Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced > it but I couldn't find ANY usage of it to fix. Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it? (In reply to Jonathan Druart from comment #6) > (In reply to Blou from comment #3) > > Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced > > it but I couldn't find ANY usage of it to fix. > > Same for me. Jared, could you confirm your development for Offline > circulation (bug 10240) includes this js file but don't use it? The offline circulation module includes the file via doc-head-close.inc. If the file is changed there, it must be changed in the manifest as well. Haaa :) Thanks Jared for the clarification! Created attachment 23259 [details] [review] [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested existing shortcuts for the search bar tabs on various circulation related pages. This uses a Javascript under BSD license, I wonder if it should be listed in the About>licenses section that we are using it. As Yui is also BSD I assume the license is compatible. +/** + * http://www.openjs.com/scripts/events/keyboard_shortcuts/ + * Version : 2.01.B + * By Binny V A + * License : BSD + */ Created attachment 23260 [details] [review] [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comment on attachment 23259 [details] [review] [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Please have different subjects on various patches - or git bz automatically obsoletes the first when attaching the second :) Also, Galen - please can you take a look at my note on the first patch before pushing? Pushed to master, along with followups to move it out of jquery/plugins (as shortcuts.js is not actually a jQuery plugin) and to update the About | Licenses page. Thanks, Philippe! Those patches has been pushed to 3.14.x, will be in 3.14.1. |