Summary: | Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page | ||
---|---|---|---|
Product: | Koha | Reporter: | Shane Sammons <ssammons> |
Component: | Templates | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, julian.maurice, kyle, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 16709 | ||
Attachments: |
Bug 11038: Enable use of IntranetUserCSS on staff client login page
Bug 11038: Enable use of IntranetUserCSS on staff client login page Bug 11038: Enable use of IntranetUserCSS on staff client login page Bug 11038: Enable use of IntranetUserCSS on staff client login page |
Description
Shane Sammons
2013-10-11 13:16:00 UTC
The staff client login page does not load CSS stored in the IntranetUserCSS system preference. While it does load intranetcolorstylesheet, it loads the file before it loads login.css, so any styles you add specific to the login page will be overridden by login.css. *** Bug 14475 has been marked as a duplicate of this bug. *** Created attachment 45219 [details] [review] Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. (In reply to Owen Leonard from comment #1) > The staff client login page does not load CSS stored in the IntranetUserCSS > system preference. Is this by design? This patch fixes this in a simple way Could this affect other pages? Created attachment 45220 [details] [review] Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Created attachment 45237 [details] [review] Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 45273 [details] [review] Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master! Thanks Bernardo! Note: I would have preferred to see a switch to using Koha.Preference, but this works well enough. At some point we will have to require the use of Koha.Preference and start a cleanup project for prefs passed via pl scripts. Patch pushed to 3.22.x, will be in 3.22.1 This patch has been pushed to 3.20.x, will be in 3.20.7. |