Bug 11048

Summary: Fix logout redirection for CAS authentication
Product: Koha Reporter: Matthias Meusburger <matthias.meusburger>
Component: AuthenticationAssignee: Matthias Meusburger <matthias.meusburger>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dpavlin, gitbot, gmcharlt, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: proposed patch
Bug 11048: Fix logout redirection for CAS authentication
[PASSED QA] Bug 11048: Fix logout redirection for CAS authentication

Description Matthias Meusburger 2013-10-14 09:22:53 UTC
The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout.
Comment 1 Matthias Meusburger 2013-10-14 09:30:09 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-30 07:10:53 UTC
Patch applied cleanly, go forth and signoff
Comment 3 Chris Cormack 2013-12-22 22:23:25 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-12-29 14:29:31 UTC
Created attachment 23865 [details] [review]
[PASSED QA] Bug 11048: Fix logout redirection for CAS authentication

The logout redirection function after a CAS authentication was misused.
 This patch fixes it, and allows the CAS server to redirect the user back
 to the opac after logout.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

From the Authen::Cas::Client documentation

logout_url [%args]
         "logout_url()" returns the CAS server's logout URL which can
	 be used to redirect users to end
         authenticated sessions.  %args may contain the following
	 optional parameter:

         *   url => $url

	 If present, the CAS server will present the user
	 with a link to the given URL once the user has logged out.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Change only affects CAS authentication and is correct
according to the module documentation.
Comment 5 Galen Charlton 2014-05-05 05:20:58 UTC
Pushed to master.  Thanks, Matthias!