Summary: | Fix logout redirection for CAS authentication | ||
---|---|---|---|
Product: | Koha | Reporter: | Matthias Meusburger <matthias.meusburger> |
Component: | Authentication | Assignee: | Matthias Meusburger <matthias.meusburger> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dpavlin, gitbot, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
Bug 11048: Fix logout redirection for CAS authentication [PASSED QA] Bug 11048: Fix logout redirection for CAS authentication |
Description
Matthias Meusburger
2013-10-14 09:22:53 UTC
Created attachment 21979 [details] [review] proposed patch Patch applied cleanly, go forth and signoff Created attachment 23768 [details] [review] Bug 11048: Fix logout redirection for CAS authentication The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> From the Authen::Cas::Client documentation logout_url [%args] "logout_url()" returns the CAS server's logout URL which can be used to redirect users to end authenticated sessions. %args may contain the following optional parameter: * url => $url If present, the CAS server will present the user with a link to the given URL once the user has logged out. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 23865 [details] [review] [PASSED QA] Bug 11048: Fix logout redirection for CAS authentication The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> From the Authen::Cas::Client documentation logout_url [%args] "logout_url()" returns the CAS server's logout URL which can be used to redirect users to end authenticated sessions. %args may contain the following optional parameter: * url => $url If present, the CAS server will present the user with a link to the given URL once the user has logged out. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Change only affects CAS authentication and is correct according to the module documentation. Pushed to master. Thanks, Matthias! |