Created attachment 22094 [details] [review] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Created attachment 22105 [details] [review] [SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language Created attachment 22108 [details] [review] [SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Created attachment 22325 [details] [review] Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold There is a problem with how an active single language is styled, making the alignment look incorrect. This patch amends the markup and the CSS to make it look better. This patch does not address the position of the language menu. To test you must have at least one additional single translation installed. Apply the patch, refresh the page, and confirm that the display of the active language is improved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improved view of current language. No koha-qa errors. 1) Downloaded a couple of xx-YY-bootstrap.po from http://translate.koha-community.org/projects/314 2) Installed sample languages 3) Enable them and opaclanguagesdisplay 4) Checked correct alignment of selected language Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The selected language has not a padding, contrary to others. Not perfect but it fixes the descripted behavior. Pushed to master. Thanks, Owen! I am setting this back to ASSIGNED, however -- the patch that was submitted addresses the side issue that Magnus identified, but does not address the main intent of the bug, which is making the language chooser visible without always requiring scrolling. This is still a problem we experience in Koha 3.18.5.1 - even for an almost empty Koha start page the language chooser is hiding. This is a problem as people have problems locating it as they don't expect it to be hidden below. Created attachment 38870 [details] [review] Bug 11057: Bootstrap theme: Don't hide language chooser below the fold This patch removes one attribute from one class on opac.less Generated css files show language changer all the time To test: 1) Update and translate for a anguage of your choice 2) Enable lang on OPAC, also allow opaclanguagesdisplay 3) Go to OPAC, note language changer 'hidden', scroll to view 4) Apply the patch 5) Check you have node.js and lessc (nodejs and node-less packeages) 6) Compile and replace new opac.css lessc --compress koha-tmpl/opac-tmpl/bootstrap/less/opac.less > koha-tmpl/opac-tmpl/bootstrap/css/opac.css 7) Reload OPAC, check language changer is visible without scrolling. 8) Check Advanced search, Authority search, Tag cloud, Login page, etc Language changer must be visible without scroll I do not provide a new opac.css Hope Owen could take a look Created attachment 39289 [details]
"Powered by Koha" getting cut into
Hi Bernardo,
Ran the tests (both pre and post patching). The switcher panel *does* stay visible in place after patch. But I'm having the "Powered by Koha" cut away. 'opaccredits' is not impacted,
-idg
Hm, I only see a difference with and without the patch with a recompiled css file - attaching as a follow-up. Created attachment 39290 [details] [review] Bug 11057: Follow-up - Bootstrap theme - recompiled css file (In reply to Katrin Fischer from comment #10) > Hm, I only see a difference with and without the patch with a recompiled css > file - attaching as a follow-up. Yeah, that's point 6) in test plan :) (In reply to Indranil Das Gupta from comment #9) > Created attachment 39289 [details] > "Powered by Koha" getting cut into > > Hi Bernardo, > > Ran the tests (both pre and post patching). The switcher panel *does* stay > visible in place after patch. But I'm having the "Powered by Koha" cut away. > 'opaccredits' is not impacted, > > -idg I can reproduce, so it's not ready and needs more work. Thanks for testing :) Now we have Bug 14252, if pass then it makes this bug moot. As a local fix I currently tried sticking this into OPACuserCSS:
.navbar-fixed-bottom.navbar-static-bottom {
margin-top: .5em;
position: absolute;
bottom: 0;
left: 0;
}
Seems to work (and I guess it does the same thing more or less).
(In reply to Viktor Sarge from comment #15) > Seems to work (and I guess it does the same thing more or less). No :( If you make a search, and then scroll down, language bar moves up, fixed in the page (tested with Chrome) Agreed. Way to easy to reproduce that one :) I'd still like to see a fix for this - some libraries like the languages in the footer better than in the top menu. I wonder if this is still needed. The display of the language chooser appears ok now to me, especially with bug 22680. This has been fixed. |
Created attachment 22008 [details] The chosen language is displayed above the other text in the language chooser With the (beautiful!) new theme based on Bootstrap, even if there is not a lot of stuff on the front page of the OPAC, the language chooser is hidden "below the fold", so you have to scroll to see it. I needed to have it pointed out to me by someone who was already aware of this, so I think there is a good chance more people will be confused by it. Also, the chosen language is displayed a bit wonky, see attached screenshot.