Bug 11061

Summary: Koha::Calendar::_mock_init is unused
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 9209    
Bug Blocks: 11112    
Attachments: Bug 11061: Koha::Calendar::_mock_init is unused
Bug 11061: Koha::Calendar::_mock_init is unused
Bug 11061: Koha::Calendar::_mock_init is unused

Description Jonathan Druart 2013-10-16 11:54:51 UTC
Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init
The routine can be removed.
Comment 1 Jonathan Druart 2013-10-16 11:56:35 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2013-10-27 02:37:25 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-11-22 18:24:06 UTC
Created attachment 23101 [details] [review]
Bug 11061: Koha::Calendar::_mock_init is unused

Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init
The routine can be removed.

Test plan:
prove t/Calendar.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
I left that routine because I planned to do a follow-up for that so the
Calendar patch series was pushed soon. Nice catch Jonathan, works as expected.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, t and xt
Comment 4 Galen Charlton 2013-11-23 19:27:47 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2013-12-13 08:14:34 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1
Comment 6 Tomás Cohen Arazi 2013-12-16 13:41:15 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!