Summary: | Clicking 'select all' link in export tab in checkout page clears renew checkboxes | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11075 - 'select all' export clears renew checkboxes
Bug 11075 - 'select all' export clears renew checkboxes [PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes |
Description
Galen Charlton
2013-10-17 16:56:12 UTC
Created attachment 23070 [details] [review] Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Galen, I took the liberty of copying your description in the commit message. Created attachment 23850 [details] [review] Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23856 [details] [review] [PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script - one line JavaScript change. Works as described. Pushed to master. Thanks, Jonathan! Patch pushed to 3.14.x, will be in 3.14.3. |